Skip to content

fix: resolve dark mode contrast issues on legal pages#7712

Open
AnkitRewar11 wants to merge 3 commits intolayer5io:masterfrom
AnkitRewar11:fix/dark-mode-legal-pages-contrast
Open

fix: resolve dark mode contrast issues on legal pages#7712
AnkitRewar11 wants to merge 3 commits intolayer5io:masterfrom
AnkitRewar11:fix/dark-mode-legal-pages-contrast

Conversation

@AnkitRewar11
Copy link
Copy Markdown
Contributor

Description
This PR fixes #7677

In dark mode, text on Code of Conduct and Terms of Service pages was invisible (dark text on dark background). On Privacy page, the data processing table was rendering in light mode regardless of user's theme preference. Issue resolved only after manually switching theme.

Root Cause

  • terms.style.js had no color properties defined, so text became invisible in dark mode
  • privacy/index.jsSistentThemeProvider was rendering with wrong initial theme before ThemeManager resolved correct theme from localStorage
  • sub-processors/index.jsSistentThemeProvider was not re-mounting on theme change

Changes Made

  • terms.style.js: added props.theme.whiteToBlack color for all text elements to ensure proper contrast in dark and light mode
  • privacy/index.js: added didLoad flag to defer SistentThemeProvider render until theme is fully resolved, preventing incorrect light mode flash on table
  • sub-processors/index.js: added key={isDark ? "dark" : "light"} to SistentThemeProvider to force re-mount on theme change

Notes for Reviewers
No new dependencies added. Changes are scoped only to legal pages.

Signed commits

  • Yes, I signed my commits.

Uploading Screen Recording 2026-05-07 040211.mp4…

Uploading Screen Recording 2026-05-07 040211.mp4…

Uploading Screen Recording 2026-05-07 040211.mp4…

Uploading Screen Recording 2026-05-07 040211.mp4…

Signed-off-by: ankitrewar11 <ankitrewar11@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

🚀 Preview deployment: https://layer5.io/pr-preview/pr-7712/

Note: Preview may take a moment (GitHub Pages deployment in progress). Please wait and refresh. Track deployment here

Copy link
Copy Markdown
Member

@rishiraj38 rishiraj38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnkitRewar11, the issue persists. Please check the preview.

@AnkitRewar11
Copy link
Copy Markdown
Contributor Author

@rishiraj38
Bro, are you sure the preview is working correctly? Because when I build it locally, I’m not seeing any issue.

@AnkitRewar11
Copy link
Copy Markdown
Contributor Author

@rishiraj38
I’m not able to share the video here. I’ll send it to you on Slack, please check it there.

@rishiraj38
Copy link
Copy Markdown
Member

@AnkitRewar11, try a commit and rebuild the preview. there’s some issue with the current preview; the whole built-in integration component is showing up.

@AnkitRewar11 AnkitRewar11 requested a review from rishiraj38 May 8, 2026 11:40
@Bhumikagarggg
Copy link
Copy Markdown
Contributor

@AnkitRewar11 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dark mode text rendering issue on Code of Conduct and Terms of Service pages (fixed after refresh)

3 participants