fix: resolve dark mode contrast issues on legal pages#7712
fix: resolve dark mode contrast issues on legal pages#7712AnkitRewar11 wants to merge 3 commits intolayer5io:masterfrom
Conversation
Signed-off-by: ankitrewar11 <ankitrewar11@gmail.com>
|
🚀 Preview deployment: https://layer5.io/pr-preview/pr-7712/
|
rishiraj38
left a comment
There was a problem hiding this comment.
@AnkitRewar11, the issue persists. Please check the preview.
|
@rishiraj38 |
|
@rishiraj38 |
|
@AnkitRewar11, try a commit and rebuild the preview. there’s some issue with the current preview; the whole built-in integration component is showing up. |
|
@AnkitRewar11 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
Description
This PR fixes #7677
In dark mode, text on Code of Conduct and Terms of Service pages was invisible (dark text on dark background). On Privacy page, the data processing table was rendering in light mode regardless of user's theme preference. Issue resolved only after manually switching theme.
Root Cause
terms.style.jshad no color properties defined, so text became invisible in dark modeprivacy/index.js—SistentThemeProviderwas rendering with wrong initial theme beforeThemeManagerresolved correct theme from localStoragesub-processors/index.js—SistentThemeProviderwas not re-mounting on theme changeChanges Made
terms.style.js: addedprops.theme.whiteToBlackcolor for all text elements to ensure proper contrast in dark and light modeprivacy/index.js: addeddidLoadflag to deferSistentThemeProviderrender until theme is fully resolved, preventing incorrect light mode flash on tablesub-processors/index.js: addedkey={isDark ? "dark" : "light"}toSistentThemeProviderto force re-mount on theme changeNotes for Reviewers
No new dependencies added. Changes are scoped only to legal pages.
Signed commits
Uploading Screen Recording 2026-05-07 040211.mp4…
Uploading Screen Recording 2026-05-07 040211.mp4…
Uploading Screen Recording 2026-05-07 040211.mp4…
Uploading Screen Recording 2026-05-07 040211.mp4…