Skip to content

Step 3: Sync score update from probes#2298

Draft
Tomelia1999 wants to merge 1 commit into
epochFloor-implementationfrom
step-3-sync-score-from-probes
Draft

Step 3: Sync score update from probes#2298
Tomelia1999 wants to merge 1 commit into
epochFloor-implementationfrom
step-3-sync-score-from-probes

Conversation

@Tomelia1999

Copy link
Copy Markdown
Contributor

Summary

Probes now contribute to the sync score in addition to availability and latency. AppendProbeRelayData gains a syncBlock uint64 parameter; the sync-scoring path mirrors appendRelayData with probe weight (0.25). The new write path to latestSyncData.Block is protected by Step 2's majorityBaseline guard.

Docs

  • Detailed proposal: protocol/rpcconsumer/docs/probing/improvements-proposals/syncBlock-penalty.md
  • Progress: protocol/rpcconsumer/docs/probing/improvements-proposals/fixes-progress.md (Step 3)

Test plan

  • `go test ./protocol/... ./ecosystem/cache/...` green
  • New unit tests in `provider_optimizer_test.go` covering sync-block update, regression detection, syncBlock=0 skip, relay-vs-probe weight comparison

Stacked PR

Depends on #2297 (Steps 1+2). Targets `epochFloor-implementation`.

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented May 25, 2026

Copy link
Copy Markdown

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Step 3: Sync score update from probes". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@Tomelia1999 Tomelia1999 force-pushed the step-3-sync-score-from-probes branch from f41a68a to 292ec46 Compare May 27, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant