Long pillar data is rendered slow by codemirror#375
Open
drscream wants to merge 2 commits into
Open
Conversation
The pillar data is available at the page load but the rendering via codemirror takes really long. By limiting the size of the area it helps a lot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the pillar data is big and nested loading the pillar tab on the minion page takes really long. Sometimes the browser freezes completely. The easiest solution (and maybe only a workaround) would the limitation of vue-codemirror window size.
Additional to that change a scroll bare is automatically added to the vue-codemirror window. For that reason it's required to modify the v-speed-dial button index to be always on top.