Order return dict for correct result parsing in Vue.JS#369
Open
drscream wants to merge 3 commits into
Open
Conversation
Because the return html code is parsed by Vue.JS to display it for example at the run result page it's required to have always the same order. Vue.JS requires the latest element to be the jid (job id) so the links are created with the correct value.
Contributor
|
could you please provide an example for when this issue occurs? |
Contributor
Author
|
Hello @mattLLVW , I need to admit that I could not reproduce the issue at the moment. It was probably based on the number of minions and how fast a return is. The easiest solution was a sort be be 100% sure how the return will look like. best regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In RunCard.vue#L376 it's expected that the first part of the return value is always the
jidso the links are generated correctly. But the dict isn't ordered so if you've more minions it could happen that thejidis the last entry in the dict.This code sort the dict in reverse order so
jidis always the first part of the dict.