Skip to content

update postgres_pgx: default configuration #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
unloop merged 1 commit into from
Feb 16, 2025
Merged

update postgres_pgx: default configuration #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions postgres_pgx/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,21 @@ type Options struct {

// Config defines the database configuration parameters
type Config struct {
DSN string `env:"DSN" envDefault:"" comment:"DSN = postgresql://[user[:password]@][netloc][:port][/dbname][?param1=value1&...] complete connection string"`
Host string `env:"HOST" envDefault:"127.0.0.1" comment:"The host to connect to"`
Port int32 `env:"PORT" envDefault:"5432" comment:"The port to connect to"`
Database string `env:"DATABASE" envDefault:"postgres" comment:"Database name"`
Username string `env:"USERNAME" envDefault:"postgres" comment:"The username to connect with"`
Password string `env:"PASSWORD" envDefault:"" comment:"The password to connect with"`
SSLMode string `env:"SSLMODE" envDefault:"disable" comment:"SSL mode (disable, allow, prefer, require, verify-ca, verify-full)"`
MaxPoolSize int `env:"MAX_POOL_SIZE" envDefault:"10" comment:"Max pool size"`
ConnAttempts int `env:"CONN_ATTEMPTS" envDefault:"10" comment:"Connection attempts"`
ConnTimeout time.Duration `env:"CONN_TIMEOUT" envDefault:"15s" comment:"Connection timeout"`
MigrationsDir string `env:"MIGRATIONS_DIR" comment:"Migrations directory"`
DSN string `env:"DSN" envDefault:"" comment:"DSN = postgresql://[user[:password]@][netloc][:port][/dbname][?param1=value1&...] complete connection string"`
Host string `env:"HOST" envDefault:"127.0.0.1" comment:"The host to connect to"`
Port int32 `env:"PORT" envDefault:"5432" comment:"The port to connect to"`
Database string `env:"DATABASE" envDefault:"postgres" comment:"Database name"`
Username string `env:"USERNAME" envDefault:"postgres" comment:"The username to connect with"`
Password string `env:"PASSWORD" envDefault:"" comment:"The password to connect with"`
SSLMode string `env:"SSLMODE" envDefault:"disable" comment:"SSL mode (disable, allow, prefer, require, verify-ca, verify-full)"`
MaxPoolSize int `env:"MAX_POOL_SIZE" envDefault:"50" comment:"Max pool size"`
MinPoolSize int `env:"MIN_POOL_SIZE" envDefault:"10" comment:"Min pool size"`
MaxConnLifetime time.Duration `env:"MAX_CONN_LIFETIME" envDefault:"1h" comment:"Maximum connection lifetime"`
MaxConnIdleTime time.Duration `env:"MAX_CONN_IDLE_TIME" envDefault:"30m" comment:"Maximum connection idle time"`
HealthCheckPeriod time.Duration `env:"HEALTH_CHECK_PERIOD" envDefault:"1m" comment:"Health check period"`
ConnAttempts int `env:"CONN_ATTEMPTS" envDefault:"3" comment:"Connection attempts"`
ConnTimeout time.Duration `env:"CONN_TIMEOUT" envDefault:"5s" comment:"Connection timeout"`
MigrationsDir string `env:"MIGRATIONS_DIR" comment:"Migrations directory"`
}

// TestConfig extends Config with additional testing-specific options
Expand Down Expand Up @@ -371,8 +375,12 @@ func (p *plugin) initPlugin(ctx context.Context) error {
return fmt.Errorf("failed to parse connection string: %w", err)
}

// Set pool configuration
// Set pool configuration with production-ready settings
config.MaxConns = int32(p.opts.MaxPoolSize)
config.MinConns = int32(p.opts.MinPoolSize)
config.MaxConnLifetime = p.opts.MaxConnLifetime
config.MaxConnIdleTime = p.opts.MaxConnIdleTime
config.HealthCheckPeriod = p.opts.HealthCheckPeriod
config.ConnConfig.ConnectTimeout = p.opts.ConnTimeout

var lastErr error
Expand Down