Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HeadManageris a singleton, but it resolves the request scopedCurrentHead(as well asSsrStateand the request) from the container it was constructed with.Under Octane the application is booted once per worker and cloned for every request.
HeadManageris usually resolved while booting (anyHead::defaults()call in a service provider does that), so it keeps a reference to the worker's base container, andCurrentHeadis resolved into the base container instead of the request's clone:RequestTerminated, and the next request on that worker starts with the previous request's title, description, canonical and the rest of its head data.This PR resolves the request scoped state from
Container::getInstance(), which Octane swaps for every request (the approach the Octane docs recommend for singletons that need the container). In a regular application the current container is the application itself, so nothing changes there. A test simulates two cloned request containers and asserts that the head data of the first one doesn't reach the second.