Repository navigation
Request the environment include when fetching domains - #280
Open
jigar-dhulla wants to merge 1 commit into
Open
jigar-dhulla wants to merge 1 commit into
jigar-dhulla wants to merge 1 commit into
Conversation
Author
|
I checked this against the live API with real calls (read-only, one domain attached to one environment). The
So |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API only returns a relationship when the request names it in
include(same cause as #276).domain:getanddomain:listnever asked forenvironment, soenvironmentIdwas alwaysnull. Domains now request it by default, and a test covers both get and list.Related to #279. This fixes
environmentIdonly.environment:getalready requestsprimaryDomainby default, anddomainsis not in the environment endpoint's documentedincludevalues, sodomainIdsis still empty. That part needs the API to allowinclude=domains, or the CLI to fill it from the domain list.