Add MeshDenoiserKit Swift package for iOS/macOS#4
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e31fb9fa5b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| path: "Sources/OpenMeshCore", | ||
| publicHeadersPath: "include", |
There was a problem hiding this comment.
With this target exported through publicHeadersPath, SwiftPM builds OpenMesh as a Clang module; compiling CMeshDenoiserCore then fails because OpenMesh/Core/IO/SR_binary_spec.hh includes another OpenMesh header while namespace OpenMesh::IO is open, which Clang diagnoses as redundant #include of module 'OpenMeshCore' appears within namespace 'OpenMesh::IO'. I verified swift test fails before any tests run, so the new package cannot currently build until the OpenMesh headers are made module-safe or are consumed without this module boundary.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in fd637b8. The OpenMesh headers are no longer exposed through publicHeadersPath — they moved to a Headers directory consumed via textual -I search paths only, so no Clang module is generated over them. A comment-only shim header satisfies SwiftPM's public-headers requirement for the target. Could not reproduce the module diagnostic on Xcode 27 beta (either build system), but the construct was toolchain-fragile and unnecessary regardless — nothing should import OpenMeshCore.
| name: "MeshDenoiserKitTests", | ||
| dependencies: ["MeshDenoiserKit"], | ||
| path: "Tests/MeshDenoiserKitTests", | ||
| resources: [.copy("Fixtures")] |
There was a problem hiding this comment.
The test target declares Fixtures as a copied resource, but the committed tree under Tests/MeshDenoiserKitTests contains only the Swift test/helper files and no Fixtures directory; swift test already warns Invalid Resource 'Fixtures': File not found. Once the package compiles, GoldenParityTests force-loads noisy_icosphere.obj and golden_denoised.obj from that resource directory, so the package test suite will fail unless those OBJ fixtures are committed or the resource/test is adjusted.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in fd637b8. Root cause: the repo's pre-existing *.obj gitignore rule (intended for MSVC object files) silently excluded the Wavefront fixtures from git add. Added a negation for Tests/MeshDenoiserKitTests/Fixtures/*.obj and committed both OBJ files; swift test passes 8/8 from a clean checkout state.
…s a module - *.obj gitignore rule (meant for MSVC object files) silently excluded the Wavefront test fixtures; negate it for the Fixtures directory and commit them. - Move OpenMesh headers out of SwiftPM's public-headers path so they are consumed as textual includes, never built as a Clang module (their internal includes inside open namespaces are not module-safe). A comment-only shim header satisfies SwiftPM's public-headers requirement.
1 participant
Summary
MeshDenoiserKit, iOS 17+ / macOS 14+) with a buffers-in/buffers-out C API bridge — vertex count/order preserved so UVs/materials survivescripts/vendor_dependencies.sh; tinygltf/tinyusdz/CLI excluded from the packageDesign spec:
docs/superpowers/specs/2026-06-12-meshdenoiserkit-swift-package-design.mdTest Plan
swift test— 8 tests: contract (count/order, NaN/index/params errors, cancellation, progress) + golden parityswift-packagejob passes on macos-15