Vendor MeshSDFilter, add flexible CLI and metrics#3
Merged
lanxinger merged 3 commits intoMar 21, 2026
Merged
Conversation
Drop the AliceVision FetchContent + override mechanism in favor of directly vendored algorithm files from Pete's standalone MeshDenoiser fork. This unlocks CHOLMOD solver support, spatial hashing, deterministic mode, early-stop displacement, and full pipeline metrics (JSON/CSV). New features: - Flexible CLI: 2-arg mode with built-in defaults, --help, --write-default-options, --deterministic, --metrics-json/csv, --export-precision - Input validation rejects meshes with NaN/Inf coordinates - Pipeline timing printed to stdout on every run - RunStatistics with detailed solver/timing metrics Multi-format I/O preserved: OBJ/PLY/OFF/STL (OpenMesh), glTF (tinygltf v2.9.7), USD (tinyusdz v0.9.1 pinned with SHA256). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lanxinger
force-pushed
the
claude/extend-meshdenoiser-formats-011CUpST8rYKaNpbw1ZrCaFm
branch
from
982cc52 to
e4632ce
Compare
find_package(Eigen3 3.3) can fail on some CI runners even when Eigen is installed. Add cascading fallbacks: retry without version, probe common system include paths (/usr/include/eigen3, /usr/local/include/eigen3, /opt/homebrew/include/eigen3), then try default search paths. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- actions/checkout v4 → v5 - actions/upload-artifact v4 → v5 - softprops/action-gh-release v1 → v2 Fixes Node.js 20 deprecation warnings. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--help,--write-default-options,--deterministic,--metrics-json/csv,--export-precisionTest plan
MeshDenoiser --helpshows usage with all formats and flagsMeshDenoiser input.obj out.objworks (2-arg mode, built-in defaults)MeshDenoiser options.txt input.obj out.objworks (3-arg mode)MeshDenoiser --write-default-options test.txtemits commented templateMeshDenoiser input.obj out.obj --deterministicruns single-threadedMeshDenoiser input.obj out.obj --metrics-json m.jsonwrites JSON metrics🤖 Generated with Claude Code