Skip to content
This repository was archived by the owner on Feb 17, 2026. It is now read-only.

Remove deprecated code#25

Open
Sachin Bhat (Sachin-Bhat) wants to merge 1 commit into
langchain-ai:mainfrom
Sachin-Bhat:feature-remove_deprecated_chain
Open

Remove deprecated code#25
Sachin Bhat (Sachin-Bhat) wants to merge 1 commit into
langchain-ai:mainfrom
Sachin-Bhat:feature-remove_deprecated_chain

Conversation

@Sachin-Bhat

@Sachin-Bhat Sachin Bhat (Sachin-Bhat) commented Jul 17, 2024

Copy link
Copy Markdown

Hello Eugene Yurtsev (@eyurtsev),

Here are the list of changes:

  • kork/chain.py:
    • Removal of LLMChain in favor of RunnableSequence as per LCEL
    • Fixing some imports
    • Removal of pydantic.config.Extra and instead assigning literals to the extra attribute
    • Removal of cast() and predict_and_parse() in favor of .content and invoke()
  • kork/parser.py:
    • convert the GRAMMAR to a raw string
  • kork/prompt_adapter.py:
    • Fixing some imports
    • Removal of pydantic.config.Extra and instead assigning literals to the extra attribute
  • tests/test_chain.py:
    • removing Chain.__call__() in favor of .invoke()
  • tests/test_prompt_adapter.py:
    • Fixing some imports
  • tests/utils.py:
    • Removal of pydantic.config.Extra and instead assigning literals to the extra attribute
    • addition of property _llm_type() to ensure that the test_chain passes since .invoke() needs this property to function correctly

Merging this fixes #24. Please let me know if further changes are required or if I have missed something.

Cheers,
Sachin

@Sachin-Bhat

Copy link
Copy Markdown
Author

Eugene Yurtsev (@eyurtsev) are we planning a merge soon?

@eyurtsev

Copy link
Copy Markdown
Collaborator

Hi Sachin Bhat (@Sachin-Bhat),

Kork is a prototype for agents that can take multiple sequential actions at once, but it isn't really used by the community https://pypistats.org/packages/kork, so we're not maintaining it.

We can keep the PR open in case anything changes but for now it's hard to justify putting any work at all into this package.

Eugene

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecated calls in the workflow

2 participants