fix: restore tab pane scrolling and make the app bar GitHub link opt-in by v-kessler · Pull Request #389 · lakekeeper/console

v-kessler · 2026-09-23T09:15:42Z

App-side follow-up to the console-components UI polish.

Every tab pane scrolls again (bounded scroll region per page).
The app bar GitHub link is opt-in.
Dropped Vuetify's crossfade from every page window: it applies a permanent
mix-blend-mode: plus-lighter, which renders panes invisible in light theme
(Governance > Policies most visibly). A lint rule now bans the prop.

Blocked: needs the @lakekeeper/console-components rev bump to the upcoming 0.25.0 release before merge. The pin bump lands as a later commit on this PR.

🤖 Generated with Claude Code

BEGIN_COMMIT_OVERRIDE
fix(ui): let every tab pane scroll again
fix(ui): opt in to the app bar GitHub link
fix(ui): stop window panes blending into a light background
END_COMMIT_OVERRIDE

Summary by CodeRabbit

Bug Fixes
- Fixed tab content that could become invisible in light theme.
- Improved scrolling for tall tab content so it remains accessible instead of being clipped.
- Updated tab switching to display content without a crossfade effect.

v-window sets overflow: hidden, so the full-height window added for the Tasks tab clipped every sibling pane: details, health, versioning and the rest could not be scrolled at all, since the card outside never saw the overflow. Tasks was unaffected because it wraps its content in its own scroll region. Each pane now carries one, via a .tab-window class rather than repeating the inner-div idiom per pane. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

The shared AppBar now hides it unless asked. The OSS console is where the link and its star count do their job, so it asks. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

coderabbitai · 2026-09-23T09:15:49Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 12d04821-6647-4c98-9403-7a7a22987a31

📥 Commits

Reviewing files that changed from the base of the PR and between 3e87f97 and 4a40bad.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (11)

eslint.config.mjs
package.json
src/assets/dependencies.json
src/layouts/default.vue
src/pages/governance/index.vue
src/pages/identities.vue
src/pages/warehouse/[id].namespace.[nsid].generic-table.[tid].vue
src/pages/warehouse/[id].namespace.[nsid].table.[tid].vue
src/pages/warehouse/[id].namespace.[nsid].view.[vid].vue
src/pages/warehouse/[id].namespace.[nsid].vue
src/pages/warehouse/[id].vue

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The console removes crossfade from tab windows and adds pane-specific scrolling styles to several warehouse pages. The default layout passes a GitHub visibility prop to AppBar. Dependency metadata updates the console-components version and relocates the aws-lc-rs entry.

Changes

Tab window behavior

Layer / File(s)	Summary
Remove crossfade from tab windows `eslint.config.mjs`, `src/pages/governance/index.vue`, `src/pages/identities.vue`, `src/pages/warehouse/...`	ESLint rejects the `crossfade` attribute. Tab windows remove the attribute, and related lazy-mounting comments are updated.
Set warehouse pane height and scrolling `src/pages/warehouse/...`	Warehouse tab-window containers and panes fill available height. Each pane can scroll vertically.

OSS GitHub link

Layer / File(s)	Summary
Pass the GitHub visibility prop `src/layouts/default.vue`	The layout passes `show-github` to `AppBar` when the app or navigation bar is shown.

Dependency metadata

Layer / File(s)	Summary
Update dependency metadata `package.json`, `src/assets/dependencies.json`	The console-components Git tag and package version change from 0.24.0 to 0.25.0. The `aws-lc-rs` entry moves before `aws-sdk-s3`.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Fixed issue severity: <fixed_issue_severity>Medium</fixed_issue_severity>

Merge Risk: ⚪ Minimal · up to 4a40b

The namespace tabs remain scrollable, and no issue identified here prevents merging after normal checks.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes two primary changes: restoring tab pane scrolling and making the AppBar GitHub link opt-in. It is concise, specific, and consistent with the pull request objectives.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{I hop past tabs beneath the light,
No crossfade trails across my sight.
Each pane can scroll from top to low,
While GitHub stars appear in tow.
I nibble carrots, then review.}

_{Comment @coderabbitai help to get the list of available commands.}

Vuetify's `crossfade` puts a permanent `mix-blend-mode: plus-lighter` on every window item (VWindow.css), not only while a transition runs, so a pane blends against the surface behind it — invisible on a light ground. Governance > Policies was the most visible case. Removed from every page window and backed by a lint rule; the comments that justified lazy tab unmounting by `crossfade` now give the reason that still applies. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

v-kessler and others added 2 commits September 23, 2026 08:36

fix(ui): opt in to the app bar GitHub link

d9e3234

The shared AppBar now hides it unless asked. The OSS console is where the link and its star count do their job, so it asks. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

v-kessler and others added 2 commits September 23, 2026 12:28

lint

4a40bad

v-kessler marked this pull request as ready for review September 23, 2026 11:19

coderabbitai Bot approved these changes Sep 23, 2026

View reviewed changes

v-kessler merged commit 5e3e902 into main Sep 23, 2026
8 checks passed

v-kessler deleted the fix/tab-scroll-and-app-bar branch September 23, 2026 11:22

Navigation Menu

fix: restore tab pane scrolling and make the app bar GitHub link opt-in - #389

fix: restore tab pane scrolling and make the app bar GitHub link opt-in#389
v-kessler merged 4 commits into
mainfrom
fix/tab-scroll-and-app-bar

v-kessler commented Sep 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Sep 23, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

v-kessler commented Sep 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

v-kessler commented Sep 23, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 23, 2026 •

edited

Loading