statistics visualize : 折れ線グラフの表示を増やしました#1663
Merged
Merged
Conversation
Contributor
|
Failed to generate code suggestions for PR |
Contributor
There was a problem hiding this comment.
Pull request overview
散布図（生産性・品質など）の「Find User」ウィジェットに、実際にプロットされていないユーザー（例: 作業時間が欠損していて点が描画されないユーザー）が表示されてしまう問題を解消し、ウィジェットの候補を「プロットされたユーザーのみに限定」するためのPRです。
Changes:
ScatterGraphに「プロットされたユーザー一覧」を保持・取得する仕組みを追加UserPerformance側でFind Userの候補を DataFrame 全体ではなく、実際に描画されたユーザーに変更- 回帰テストを追加して、未プロットユーザーが
Find Userに出ないことを検証 .codex/config.tomlを削除
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/statistics/visualization/dataframe/test_user_performance.py | 未プロットユーザーがHTML（Find User候補）に含まれないことを検証するテストを追加 |
| annofabcli/statistics/visualization/dataframe/user_performance.py | Find User の候補を「描画済みユーザー」に限定するよう呼び出しを変更 |
| annofabcli/statistics/scatter.py | 描画済みユーザーを収集し get_plotted_users() で返す機能を追加 |
| .codex/config.toml | 設定ファイルを削除 |
Comment on lines
+406
to
+413
| for (const renderer of [lineRenderer, markerRenderer]) { | ||
| renderer.glyph.y.field = selected.valueColumn; | ||
| renderer.glyph.change.emit(); | ||
| } | ||
| movingAverageRenderer.glyph.y.field = selected.movingAverageColumn; | ||
| movingAverageRenderer.glyph.change.emit(); | ||
| figureTitle.text = selected.title; | ||
| figureTitle.change.emit(); |
Comment on lines
+1143
to
+1150
| for (const renderer of [lineRenderer, markerRenderer]) { | ||
| renderer.glyph.y.field = selected.valueColumn; | ||
| renderer.glyph.change.emit(); | ||
| } | ||
| movingAverageRenderer.glyph.y.field = selected.movingAverageColumn; | ||
| movingAverageRenderer.glyph.change.emit(); | ||
| figureTitle.text = selected.title; | ||
| figureTitle.change.emit(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.