Skip to content

Code Refactoring #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
param-b wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Code Refactoring #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45498ee
Add files via upload
param-b May 1, 2020
538874f
Merge pull request #1 from param-b/param-b-patch-1
param-b May 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Readme_Changes.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
Changes Made:

Sem hash functions are purposely kept inside the .py file and new class has not been created to match the file name ohterwise such addittional change can be made to put them in once class in anoter file

Class MeraDatset is transferred to a new file to reduce clutter
Functions clubbed together to improve clarity and testing ability of individual function if assigned individual cell in Jupyter Notebook or any other .ipynb
Reduced the number of lines left
Comments also mentioned above the changes Made
read_csv is transferred to new file to increase reusability
plot_results() is transferred to new file to increase reusability
tokenize, preprocess, data_for_training, get_vectorizer moved to creating_data_train_test.py to improve readibilty and reusability
Loading