Skip to content

improve: correct calculation of file size when using stripHash function.#9

Open
stephen-liu-fipo wants to merge 1 commit into
kuldeepkeshwar:masterfrom
stephen-liu-fipo:master
Open

improve: correct calculation of file size when using stripHash function.#9
stephen-liu-fipo wants to merge 1 commit into
kuldeepkeshwar:masterfrom
stephen-liu-fipo:master

Conversation

@stephen-liu-fipo

Copy link
Copy Markdown

when using stripHash functioin. the filename

file structor

├── assets
│   ├── Add-05e23941.js
│   ├── IconButton-d130f323.js
│   ├── KeyboardArrowRight-2ba4ba71.js
│   ├── Popper-c8879c88.js
│   ├── TablePagination-f3e5f6f4.js
│   ├── index-26d0922c.js
│   ├── index-2b6194b2.js
│   ├── index-3a757292.js
│   ├── index-5fa2d481.js
│   ├── index-6227e1d5.js
│   ├── index-959e0bf0.js
│   ├── index-96869e9a.js
│   ├── index-9b2e168d.js
│   ├── index-bc581656.js
│   └── index-efdcc4d5.js
├── index.html
└── vite.svg
name: Compressed Size

on: [pull_request]

jobs:
  build:
    runs-on: ubuntu-latest
    permissions:
      pull-requests: write
      contents: read
    steps:
      - uses: actions/checkout@v2
      - uses: ./.github/actions/size
        with:
          strip-hash: "\\-(\\w{8})\\.js$"
          compression: "none"
          build-script: "build:notsc"

before: If the fileName remains unchanged after the stripHash function(index-efdcc4d5.js -> index-.js, index-bc581656.js -> index-.js and other index files), the file size will only be calculated once.

after: file size should be calculated together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant