Feat add support for other two pots#3
Open
SpyrosCpt wants to merge 3 commits into
Open
Conversation
Owner
|
Thank you for the proposed features. The proposed features are suitable for a 4 channel potentiometer. This library is for MCP4251 which is a 2 channel potentiometer. If the proposed features are to be merged, then the name of the library needed to be changed to generic term like MCP4X51. Changing name of the library to incorporate new features after publishing may not be a good idea. Better idea would be to create a new library with generic terminology (MCP4XXX) or for the specific 4 channel pot (e.g. MCP4451) which will cover all the use cases for potentiometer 1 to 4. Also, one of the commit is directly relevant to issue at #2 (comment) which is still pending due to my other commitments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
I noticed that when using this library I could only control 2/4 Potentiometers.
I have added support for the other two.
Important mentions: