Skip to content

Feature/add columns component#20

Open
dotamir wants to merge 2 commits into
kulakowka:masterfrom
dotamir:feature/columns
Open

Feature/add columns component#20
dotamir wants to merge 2 commits into
kulakowka:masterfrom
dotamir:feature/columns

Conversation

@dotamir

@dotamir dotamir commented Dec 18, 2017

Copy link
Copy Markdown

No description provided.

@dotamir

dotamir commented Dec 18, 2017

Copy link
Copy Markdown
Author

I've just made the basics. It will be complete, And please left your comments and lemme know what you think and what is your idea?
Let's work together on this.

@dotamir dotamir changed the title Feature/add columns components Feature/add columns component Dec 18, 2017
@skbolton

Copy link
Copy Markdown

I am really hopeful for this to get added but I think some changes could be made.
The text alignment can always be passed in as a className so it just adds overhead to the api and documentation. Also I think having the gap and multiline props would be nice

@dotamir

dotamir commented Dec 27, 2017

Copy link
Copy Markdown
Author

@skbolton Yeah, I'm with you. And I've deleted the text alignments. Also, I'll commit the new changes.

@skbolton

skbolton commented Jan 3, 2018

Copy link
Copy Markdown

I think to match the api elsewhere the is part of the props should be dropped so

<Columns multiline gapless>
  <Column is={2}>
    <h1>Hey there</h1>
  </Column>
</Columns>

instead of

<Columns isMultiline isGapless>
  <Column is="is-2">
    <h1>Hey there</h1>
  </Column>
</Columns>
  

@dotamir

dotamir commented Jan 10, 2018

Copy link
Copy Markdown
Author

@skbolton Can you do that? I just busy right now.

@skbolton

Copy link
Copy Markdown

Yeah I can get it

@kulakowka kulakowka mentioned this pull request Apr 20, 2018
@dotamir

dotamir commented May 8, 2018

Copy link
Copy Markdown
Author

@kulakowka Let's work on it together. What's your idea about it until here?
gimme a feedback and I'll complete this.

@scorsi

scorsi commented Sep 16, 2018

Copy link
Copy Markdown

Do you have some news about the Columns feature progress ? :)

@juanbrujo

Copy link
Copy Markdown

This feature is important, will be fixed and merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants