[quality] unit tests for LLMd utility functions (KVCacheMonitor.utils + nightlyE2E.constants) by clubanderson · Pull Request #19662 · kubestellar/console

clubanderson · 2026-06-26T00:40:20Z

Test Improvement

Adds 50+ unit tests for two previously-untested pure utility modules in web/src/components/cards/llmd/:

`KVCacheMonitor.utils.test.ts` (40+ tests)

calculateAggregateMetrics: empty input, single stat, multiple stats averaging
calculateTrend: empty, single, increasing, decreasing, flat history
updatePodHistory: new pod creation, appending, history trimming to 20-item limit
getGaugeGridClass: flex vs grid layout selection for expanded/collapsed states
getGaugeSize: size scaling by item count and expansion state
getHorseshoeGridClass: grid column adaptation
getHorseshoeSize: size scaling
getHeatCellColors: all 5 threshold bands + boundary values
getDisplayPodName: aggregate name translation, vllm- prefix stripping, truncation
generateMonitorStats: empty stack, demo mode, aggregated/disaggregated modes
exported constants: HEATMAP_LEGEND structure, DIV_STYLE constants

`nightlyE2E.constants.test.ts` (15+ tests)

getGuideMeta: full data, missing fields, partial data
computeAvgDurationMin: empty array, no completed runs, average calculation, filtering non-completed, missing timestamps
formatDuration: minutes-only, hours-only, hours+minutes formatting
constants: PLATFORM_ORDER, PLATFORM_COLORS, chart dimensions

Partially addresses #19631 — targets the remaining untested utility files in web/src/components/cards/llmd/.

Filed by quality agent (ACMM L4/L6 — full mode)

Signed-off-by: clubanderson <clubanderson@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

kubestellar-prow · 2026-06-26T00:40:24Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify · 2026-06-26T00:40:25Z

✅ Deploy Preview for kubestellarconsole ready!

Name	Link
🔨 Latest commit	`bb45b95`
🔍 Latest deploy log	https://app.netlify.com/projects/kubestellarconsole/deploys/6a3dcfc633023b0007952c69
😎 Deploy Preview	https://deploy-preview-19662.console-deploy-preview.kubestellar.io
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2026-06-26T00:40:28Z

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

Claude Code (Opus 4.5 / 4.6) — recommended

GitHub Copilot

Cursor

Other AI coding assistants

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.

github-actions · 2026-06-26T00:40:30Z

🐝 Hi @clubanderson! I'm kubestellar-hive[bot], an automation bot for this repo.

Trusted users — org members and contributors with write access — can mention @kubestellar-hive in a comment to trigger repo automation.
On issues, that mention queues an automated fix attempt. On pull requests, it records extra context for existing automation.
This is not an interactive Q&A bot, so mentions should be treated as requests for automation rather than a conversation.

Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies.

github-actions · 2026-06-26T00:40:48Z

✅ Test Coverage Check

All new source files in this PR have corresponding test files.

Checked web/src/hooks/ and web/src/components/ against origin/main.

Copilot

Pull request overview

This PR improves frontend test coverage by adding Vitest unit tests for two pure utility modules under web/src/components/cards/llmd/, targeting previously untested logic called out by #19631.

Changes:

Adds unit tests for KVCacheMonitor.utils helpers (aggregation, trend, history trimming, layout sizing/classes, heatmap thresholds, display name formatting, and exported constants).
Adds unit tests for nightlyE2E.constants helpers (guide metadata extraction, average duration computation, duration formatting, and key constants).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
web/src/components/cards/llmd/tests/KVCacheMonitor.utils.test.ts	Adds coverage for KV cache monitor utility functions and constants.
web/src/components/cards/llmd/tests/nightlyE2E.constants.test.ts	Adds coverage for nightly E2E constants and helper functions.

+    it('returns zeros for null/undefined-like input', () => {
+      const result = calculateAggregateMetrics([] as KVCacheStats[])
+      expect(result.avgUtil).toBe(0)
+    })


+      const stack = {
+        cluster: 'test-cluster',
+        namespace: 'llmd',
+        name: 'test-stack',
+        components: {
+          prefill: [{ name: 'prefill-svc', replicas: 2, readyReplicas: 2, podNames: ['p-0', 'p-1'] }],
+          decode: [{ name: 'decode-svc', replicas: 1, readyReplicas: 1, podNames: ['d-0'] }],
+          both: [],
+        },
+      }
+      const result = generateMonitorStats({
+        aggregationMode: 'aggregated',
+        isDemoMode: false,
+        prometheusMetrics: null,
+        selectedStack: stack as any,
+      })


+      const stack = {
+        cluster: 'test-cluster',
+        namespace: 'llmd',
+        name: 'test-stack',
+        components: {
+          prefill: [{ name: 'prefill-svc', replicas: 2, readyReplicas: 2, podNames: ['p-0', 'p-1'] }],
+          decode: [],
+          both: [],
+        },
+      }
+      const result = generateMonitorStats({
+        aggregationMode: 'disaggregated',
+        isDemoMode: false,
+        prometheusMetrics: null,
+        selectedStack: stack as any,
+      })


+        { status: 'failed', createdAt: '2026-01-01T00:00:00Z', updatedAt: '2026-01-01T00:30:00Z' },
+      ] as unknown as NightlyRun[]


+        {
+          status: 'failed',
+          createdAt: '2026-01-01T00:00:00Z',
+          updatedAt: '2026-01-01T02:00:00Z',
+        },


github-actions · 2026-06-26T01:03:31Z

Thank you for your contribution! Your PR has been merged.

Check out what's new:

KubeStellar Console — Live multi-cluster dashboard
Marketplace — Community extensions
Knowledge Base — Troubleshooting and how-tos

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

github-actions · 2026-06-26T01:09:13Z

✅ Post-Merge Verification: passed

Commit: b6bcefd96f72f736538c95d82564f06ef0ae6639
Specs run: Dashboard.spec.ts smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/28210431580

github-actions · 2026-06-26T01:10:37Z

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit b6bcefd96f72f736538c95d82564f06ef0ae6639.

Fixes the shared root cause that broke render tests across card components and mission components after PR #19662 merged. Root cause: The new test files (KVCacheMonitor.utils.test.ts and nightlyE2E.constants.test.ts) were running in the default jsdom environment instead of Node.js environment. Since they test pure utility functions that import React types, these tests were polluting the global scope when they ran, affecting subsequent jsdom tests in CI (where tests run sequentially with 1 worker). Fix: Added @vitest-environment node directive to both test files so they run in Node.js environment instead of jsdom, preventing global scope pollution. This follows the same pattern as the fix in #19663 which resolved the previous 168 test failure cascade. Signed-off-by: Copilot <copilot@users.noreply.github.com> Co-authored-by: Copilot <copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

clubanderson and others added 2 commits June 25, 2026 20:39

[quality] add unit tests for KVCacheMonitor.utils pure functions

3c4fc1d

Signed-off-by: clubanderson <clubanderson@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

[quality] add unit tests for nightlyE2E.constants pure functions

21543b7

Signed-off-by: clubanderson <clubanderson@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 26, 2026 00:40

kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Jun 26, 2026

github-actions Bot added ai-generated Pull request generated by AI tier/1-lightweight labels Jun 26, 2026

kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 26, 2026

clubanderson mentioned this pull request Jun 26, 2026

[quality] web/src/config/cards: 209 source files with zero test coverage #19631

Closed

Copilot started reviewing on behalf of clubanderson June 26, 2026 00:40 View session

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Merge branch 'main' into quality/test-llmd-utils

bb45b95

clubanderson merged commit b6bcefd into main Jun 26, 2026
28 of 30 checks passed

kubestellar-prow Bot deleted the quality/test-llmd-utils branch June 26, 2026 01:03

This was referenced Jun 26, 2026

🐛 168 test failure(s) in Coverage Suite run #3905 #19672

Closed

[quality] zero-coverage tests: web/src/components/cards/llmd (16 untested files) #19681

Closed

[scanner] fix: resolve test failures from coverage suite #3905 #19685

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[quality] unit tests for LLMd utility functions (KVCacheMonitor.utils + nightlyE2E.constants)#19662

[quality] unit tests for LLMd utility functions (KVCacheMonitor.utils + nightlyE2E.constants)#19662
clubanderson merged 3 commits into
mainfrom
quality/test-llmd-utils

clubanderson commented Jun 26, 2026

Uh oh!

kubestellar-prow Bot commented Jun 26, 2026

Uh oh!

netlify Bot commented Jun 26, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		{ status: 'failed', createdAt: '2026-01-01T00:00:00Z', updatedAt: '2026-01-01T00:30:00Z' },
		] as unknown as NightlyRun[]

Uh oh!

Conversation

clubanderson commented Jun 26, 2026

Test Improvement

KVCacheMonitor.utils.test.ts (40+ tests)

nightlyE2E.constants.test.ts (15+ tests)

Uh oh!

kubestellar-prow Bot commented Jun 26, 2026

Uh oh!

netlify Bot commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubestellarconsole ready!

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

github-actions Bot commented Jun 26, 2026

✅ Test Coverage Check

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

github-actions Bot commented Jun 26, 2026

✅ Post-Merge Verification: passed

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

`KVCacheMonitor.utils.test.ts` (40+ tests)

`nightlyE2E.constants.test.ts` (15+ tests)

netlify Bot commented Jun 26, 2026 •

edited

Loading