Migrating remaining CAPZ + Windows jobs to use templates/scripting from windows-testing repo

[marosset]

Part of kubernetes-sigs/cluster-api-provider-azure#6305
/sig windows
/assign @andyzhangx @jackfrancis @mboersma @zylxjtu

[jackfrancis]

Why don't we need to check out the CAPZ repo for this test?

[marosset]

We should still be doing that.
The diff is weird but my intention was to delete the Windows 2019 job here.
If you look at the file view (https://github.com/marosset/test-infra/blob/561a2c5ba60a3b22133f27abac31d56980e8b302/config/jobs/kubernetes-csi/csi-driver-smb/csi-driver-smb-config.yaml) all of the jobs that reference the windows-testing repo still reference CAPZ/cloud-provider-azure

[mboersma]

/lgtm

azurefile-csi-driver-config.yaml still has three other jobs using preset-azure-windows (pull-azurefile-csi-driver-e2e-migration-windows at line 179, external-e2e-smb at 250, external-e2e-nfs at 305). Just want to confirm that those are out of scope for this PR.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marosset, mboersma
Once this PR has been reviewed and has the lgtm label, please ask for approval from andyzhangx. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• config/jobs/kubernetes-csi/csi-driver-smb/OWNERS
• config/jobs/kubernetes-sigs/azuredisk-csi-driver/OWNERS
• config/jobs/kubernetes-sigs/azurefile-csi-driver/OWNERS
• config/jobs/kubernetes/sig-cloud-provider/azure/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[marosset]

/lgtm

azurefile-csi-driver-config.yaml still has three other jobs using preset-azure-windows (pull-azurefile-csi-driver-e2e-migration-windows at line 179, external-e2e-smb at 250, external-e2e-nfs at 305). Just want to confirm that those are out of scope for this PR.

I probably missed those, let me take a look

[marosset]

/lgtm

azurefile-csi-driver-config.yaml still has three other jobs using preset-azure-windows (pull-azurefile-csi-driver-e2e-migration-windows at line 179, external-e2e-smb at 250, external-e2e-nfs at 305). Just want to confirm that those are out of scope for this PR.

pull-azurefile-csi-driver-e2e-migration-windows looks correct.
For the other 2, i don't know why those had preset-azure-windows set.

That preset just sets the following which shouldn't cause anything to run on Windows machines.
I'll keep cleaning that up out of scope

- labels:
    preset-azure-windows: "true"
  env:
  - name: WIN_BUILD
    value: https://raw.githubusercontent.com/kubernetes-sigs/windows-testing/master/build/build-windows-k8s.sh
  - name: K8S_SSH_PUBLIC_KEY_PATH
    value: /etc/ssh-key-secret/ssh-public # from preset-k8s-ssh label
  - name: K8S_SSH_PRIVATE_KEY_PATH
    value: /etc/ssh-key-secret/ssh-private # from preset-k8s-ssh label
- labels:

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[andyzhangx]

/hold

we need to make sure capz windows test works on k8s 1.33 or later version

[andyzhangx]

pls don't change the existing test name

[marosset]

I think this is just showing up as a complicated diff because I removed some jobs.

Once #37125 merges, i will rebase this PR which should have a cleaning diff

[marosset]

I'm going to split this PR into multiple ones.
/close

[k8s-ci-robot]

@marosset: Closed this PR.

Details

In response to this:

I'm going to split this PR into multiple ones.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.