Skip to content

ghproxy: support git ref paths with slash-separated branch names#773

Open
valen-mascarenhas14 wants to merge 1 commit into
kubernetes-sigs:mainfrom
valen-mascarenhas14:simplify-dev
Open

ghproxy: support git ref paths with slash-separated branch names#773
valen-mascarenhas14 wants to merge 1 commit into
kubernetes-sigs:mainfrom
valen-mascarenhas14:simplify-dev

Conversation

@valen-mascarenhas14

Copy link
Copy Markdown
Contributor

Fixes: #760

What this PR does ?

This PR fixes ghproxy's path simplifier to correctly handle git reference paths where branch names contain forward slashes, such as feature/v1beta1-migrate or release/v2.0.

Previously, these paths would trigger "Path not handled" debug logs because the simplifier only matched a single path segment after refs/heads/, causing paths like /repos/kubernetes-sigs/agent-sandbox/git/refs/heads/feature/v1beta1-migrate to be unmatched.

@netlify

netlify Bot commented Jun 25, 2026

Copy link
Copy Markdown

Deploy Preview for k8s-prow ready!

Name Link
🔨 Latest commit 69b3da6
🔍 Latest deploy log https://app.netlify.com/projects/k8s-prow/deploys/6a3d116a0e42eb000934ac63
😎 Deploy Preview https://deploy-preview-773--k8s-prow.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: valen-mascarenhas14
Once this PR has been reviewed and has the lgtm label, please assign petr-muller for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @valen-mascarenhas14. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 25, 2026
@petr-muller

Copy link
Copy Markdown
Contributor

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ghproxy simplify bug

2 participants