ghproxy: support git ref paths with slash-separated branch names#773
ghproxy: support git ref paths with slash-separated branch names#773valen-mascarenhas14 wants to merge 1 commit into
Conversation
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: valen-mascarenhas14 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @valen-mascarenhas14. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Fixes: #760
What this PR does ?
This PR fixes ghproxy's path simplifier to correctly handle git reference paths where branch names contain forward slashes, such as
feature/v1beta1-migrateorrelease/v2.0.Previously, these paths would trigger "Path not handled" debug logs because the simplifier only matched a single path segment after
refs/heads/, causing paths like/repos/kubernetes-sigs/agent-sandbox/git/refs/heads/feature/v1beta1-migrateto be unmatched.