git: add SSH commit signing support to the git client factory#772
git: add SSH commit signing support to the git client factory#772Prucek wants to merge 1 commit into
Conversation
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kubernetes-prow
Bot
added
size/L
|
/hold I don't think this is the right direction. This feature needs to be embedded into the git client, since the component also uses and initializes. The key path could leave in the github options too. |
kubernetes-prow
Bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Prucek The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Prucek
force-pushed
the
cherrypicker-signed-commits
branch
from
bdef64b to
298044b
Compare
Prucek
changed the title
Add --git-signing-key-path flag to GitHubOptions. When set, the git client factory configures gpg.format=ssh, user.signingkey, and commit.gpgsign=true on every cloned repo so that commits produced by any component are signed.
Prucek
force-pushed
the
cherrypicker-signed-commits
branch
from
298044b to
6ac6774
Compare
|
After changes and discussion |
kubernetes-prow
Bot
removed
the
do-not-merge/hold
kubernetes-prow
Bot
added
the
lgtm
3 participants
Summary
--git-signing-key-pathflag toGitHubOptionsfor SSH-based commit signinggpg.format=ssh,user.signingkey, andcommit.gpgsign=trueon every cloned repoGitHubOptions(cherrypicker, tide, etc.) gets signing support automaticallyGenerated with the help of AI (Claude Code)