Fix pagination prefix duplication on GHE with redirect#754
Open
petr-muller wants to merge 1 commit into
Open
Conversation
Contributor
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Determine the GHE path prefix by matching the Link header URL host against c.bases, instead of inferring it from path suffix matching which breaks when a redirect changes the response URL path.
petr-muller
force-pushed
the
fix-748-ghe-redirect
branch
from
6bc30a8 to
55cf6c6
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
k8s-ci-robot
added
size/M
Contributor
Author
|
/cc @jmguzik |
Member
|
/lgtm |
kubernetes-prow
Bot
added
the
do-not-merge/hold
kubernetes-prow
Bot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the known limitation noted in #748: on GitHub Enterprise instances (where the base URL includes a path prefix like
/api/v3), a redirect (e.g. repo rename) causes the pagination prefix detection to fail, doubling the prefix in the next-page URL (/api/v3/api/v3/...) and producing a 404.Replaces the string-suffix-matching prefix computation with host-aware lookup: the GHE path prefix is determined by matching the Link header URL's host against
c.basesand extracting the path component. This is immune to redirects because it doesn't depend on the request/response path matching.Depends on #753.