feat: Add kube-api-linter and fix ProwJob API type annotations#750
Open
dongjiang1989 wants to merge 4 commits into
Open
feat: Add kube-api-linter and fix ProwJob API type annotations#750dongjiang1989 wants to merge 4 commits into
dongjiang1989 wants to merge 4 commits into
Conversation
Signed-off-by: dongjiang <dongjiang1989@126.com>
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
area/plugins
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dongjiang1989 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
requested review from
MadhavJivrajani,
Priyankasaggu11929 and
matthyx
k8s-ci-robot
added
cncf-cla: yes
Member
Author
|
/test pull-prow-verify-lint |
Signed-off-by: dongjiang <dongjiang1989@126.com>
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
Signed-off-by: dongjiang <dongjiang1989@126.com>
k8s-ci-robot
added
area/deck
Member
Author
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg/apis/prowjobs/v1/types.goto comply with KAL rules:commentstart: Lowercase the first word of field comments to match JSON tag names (e.g.// Type is...→// type is...)optionalorrequired: Add// +optional/// +requiredmarkers to all struct fields, replacing+kubebuilder:validation:Requiredwhere applicablehack/tools/.golangci-kal.ymlKAL configuration with enabled rules:commentstart,conflictingmarkers,duplicatemarkers,nofloats,optionalorrequired,uniquemarkers,nophase,nonullablemake lint-apitarget and integrate KAL intomake verifypipelinehack/tools/tmp/and_bin/tomake cleanfor proper build artifact cleanupFiles changed (13 files, +766 / -389)
hack/tools/.custom-gcl.yaml,.golangci-kal.yml,build-kal,go.mod,go.sum,tools.goMakefile(lint-api target, clean),hack/make-rules/verify/all.sh,kube-api-lint.shpkg/apis/prowjobs/v1/types.goprowjob_customresourcedefinition.yaml,prow-config-documented.yaml,plugin-config-documented.yaml