Skip to content

docs: run kind e2e tests #206

Merged
kubernetes-prow[bot] merged 3 commits into
kubernetes-sigs:mainfrom
Tal-or:update_kind_local_tests
Jun 26, 2026
Merged

docs: run kind e2e tests #206
kubernetes-prow[bot] merged 3 commits into
kubernetes-sigs:mainfrom
Tal-or:update_kind_local_tests

Conversation

@Tal-or

@Tal-or Tal-or commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Document the simplest way for developers to run e2e tests locally.
Also add a troubleshooting guide for common mishaps.

Signed-off-by: Talor Itzhak titzhak@redhat.com

Tal-or added 2 commits June 25, 2026 14:13
@Tal-or
e2e: add README "how to run" section
c172eca 
Explain the easiest way to trigger the tests
and troubleshooting guide.

Ref: kubernetes-sigs#132
Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@Tal-or
e2e: document rootless Docker cpuset troubleshooting
1411eff 
When running kind with rootless Docker, the cpuset cgroup controller
is not delegated to user sessions by default. This causes the NRI
hook to crash all pods (including CoreDNS) because cpuset.cpus is
missing from the cgroup hierarchy.

Add a troubleshooting entry explaining how to verify and fix the
issue by configuring systemd to delegate the cpuset controller.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@kubernetes-prow kubernetes-prow Bot requested review from johnbelamaric and pohly June 25, 2026 11:21
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 25, 2026
@Tal-or Tal-or changed the title docs: update local e2e tests documentation docs: run kind e2e tests Jun 25, 2026
ffromani
ffromani reviewed Jun 25, 2026
View reviewed changes

@ffromani ffromani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

thanks, this helps. We are close to the point we need to split our README.md file in targeted readmes, but not a concern of this PR.

@kubernetes-prow kubernetes-prow Bot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 25, 2026
@AutuSnow

AutuSnow commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

/hold

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2026
@AutuSnow

AutuSnow commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

One small doc caveat here: for the existing-cluster case, I think we should also mention the test image.

make test-e2e does not build/load the test image by itself; it only runs the Go e2e suite with DRACPU_E2E_TEST_IMAGE=$(IMAGE_TEST). In the make test-e2e-kind path that image is built and loaded by ci-kind-setup, but for an arbitrary existing cluster the default IMAGE_TEST value points at the local CI image name and probably is not pullable.

So maybe this should say that the driver must already be deployed and the test image must be available to the cluster, or that users should override DRACPU_E2E_TEST_IMAGE with a pullable test image.

@Tal-or

Tal-or commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

One small doc caveat here: for the existing-cluster case, I think we should also mention the test image.  make test-e2e does not build/load the test image by itself; it only runs the Go e2e suite with DRACPU_E2E_TEST_IMAGE=$(IMAGE_TEST). In the make test-e2e-kind path that image is built and loaded by ci-kind-setup, but for an arbitrary existing cluster the default IMAGE_TEST value points at the local CI image name and probably is not pullable.  So maybe this should say that the driver must already be deployed and the test image must be available to the cluster, or that users should override DRACPU_E2E_TEST_IMAGE with a pullable test image.

Thank you @AutuSnow for the constructive comment. I'll update that ASAP

@ffromani

ffromani commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

/approve cancel

@AutuSnow has a good point

@kubernetes-prow kubernetes-prow Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2026
@Tal-or
docs: add note about image availability
b8f231e 
Emphasis differences between `make test-e2e` and `make test-e2e-kind`
in the context of image availability

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@kubernetes-prow kubernetes-prow Bot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2026
@Tal-or

Tal-or commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Added the requested note. see last commit.
Feel free to unhold and approve if happy

@AutuSnow

AutuSnow commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

/unhold
/lgtm

@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2026
@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2026
@ffromani

ffromani commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

/approve

thanks!

@kubernetes-prow

kubernetes-prow Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2026
@kubernetes-prow kubernetes-prow Bot merged commit b9904b4 into kubernetes-sigs:main Jun 26, 2026
11 checks passed
@Tal-or Tal-or deleted the update_kind_local_tests branch June 26, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ffromani ffromani ffromani left review comments
@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric
@pohly pohly Awaiting requested review from pohly

Assignees

@ffromani ffromani

@AutuSnow AutuSnow

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Tal-or @AutuSnow @ffromani