Validate DRA env against prepared claims#194
Open
AutuSnow wants to merge 3 commits into
Open
Conversation
kubernetes-prow
Bot
added
cncf-cla: yes
pravk03
reviewed
Jun 25, 2026
pravk03
reviewed
Jun 25, 2026
pravk03
left a comment
pravk03
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this important change.
/lgtm
kubernetes-prow
Bot
added
the
lgtm
Contributor
Author
|
/hold |
kubernetes-prow
Bot
added
the
do-not-merge/hold
kubernetes-prow
Bot
removed
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AutuSnow The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/unhold |
kubernetes-prow
Bot
removed
the
do-not-merge/hold
Contributor
|
Thanks for this!! |
kubernetes-prow
Bot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRA_CPUSET_*env entries against claims prepared by this driver.
NRI
CreateContainerruns for every container, not only containers prepared through DRA. A container-providedDRA_CPUSET_*env should not be trusted unless it matches driver-owned prepare state.
This addresses the Fail closed on malformed DRA_CPUSET env #190 follow-up while preserving the intended shared-pool behavior for non-DRA containers.
Follow-up:
Fail closed on malformed DRA_CPUSET env #190 (comment)