helm: add Kubeflow foundation charts#3468
Conversation
|
Welcome to the Kubeflow Manifests Repository Thanks for opening your first PR. Your contribution means a lot to the Kubeflow community. Before making more PRs: Community Resources:
Thanks again for helping to improve Kubeflow. |
d0658e5 to
58e2aa5
Compare
58e2aa5 to
518a7c4
Compare
| # Default values for kubeflow-namespaces. | ||
|
|
||
| global: | ||
| # -- Primary Kubeflow namespace. |
There was a problem hiding this comment.
what is the purpose of such comments?
There was a problem hiding this comment.
Removed the redundant values comments in values.yaml.
| systemNamespace: kubeflow-system | ||
|
|
||
| networkPolicies: | ||
| # -- Keep namespace NetworkPolicies aligned with common/kubeflow-namespace/base. |
There was a problem hiding this comment.
what is the purpose of such comments ?
There was a problem hiding this comment.
Removed the redundant values comments in values.yaml.
45a0c78 to
b7f645f
Compare
|
There was a problem hiding this comment.
I am assuming you have captured all the netpol from https://github.com/kubeflow/manifests/tree/master/common/kubeflow-namespace/base/kubeflow kustomize
There was a problem hiding this comment.
Yes, these NetworkPolicies are copied from common/kubeflow-namespace/base/kubeflow and covered by the Helm/Kustomize comparison.
| - `Namespace/auth` | ||
| - namespace-scoped NetworkPolicies required by the platform baseline | ||
|
|
||
| If one of these namespaces already exists, for example a company-managed `cert-manager` namespace, the chart does not recreate or adopt it. Helm does not patch labels on unmanaged pre-existing resources; apply the required labels to that namespace separately if they are missing. |
There was a problem hiding this comment.
Should we also mention in the README that namespaces created by kubeflow-namespaces chart are not deleted when the chart is uninstalled via Helm?
helm uninstall kubeflow-namespaces
This would help clarify the expected behavior for users and prevent accidental assumptions about namespace cleanup during uninstallation.
There was a problem hiding this comment.
Added this to the README; namespaces created by this bootstrap chart are kept on helm uninstall.
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
7aec9b1 to
d9d83c1
Compare
|
@dhanishaphadate: changing LGTM is restricted to collaborators DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| apiVersion: networking.k8s.io/v1 | ||
| kind: NetworkPolicy | ||
| metadata: | ||
| name: metatada-envoy |
| declare -A KUSTOMIZE_PATHS=( | ||
| ["base"]="$MANIFESTS_DIR/base" | ||
| ["platform-namespaces"]="$ROOT_DIR/common/kubeflow-namespace/base"$'\n'"$ROOT_DIR/common/cert-manager/base"$'\n'"$ROOT_DIR/common/istio/istio-namespace/base"$'\n'"$ROOT_DIR/common/oauth2-proxy/base"$'\n'"$ROOT_DIR/common/dex/base" | ||
| ) |
|
@dhanishaphadate: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Summary
Adds the first two Project 5 foundation Helm charts under
experimental/helm/charts:kubeflow-namespaceskubeflow-platformkubeflow-namespacesowns the bootstrap namespace layer for the platform install. It renders the Kubeflow namespaces, platform dependency namespaces, and namespace-scoped NetworkPolicies that currently come fromcommon/kubeflow-namespace/baseplus the dependency namespace baselines.kubeflow-platformowns the shared Kubeflow platform RBAC fromcommon/kubeflow-roles/base.Scope
experimental/helm/charts/kubeflow-namespaces.experimental/helm/charts/kubeflow-platform.Namespace behavior
kubeflow-namespacesis the bootstrap chart. Its Helm release is installed indefaultbecause it createskubeflow-system.Namespaces created by this chart are kept on
helm uninstall, since later platform and component charts may create resources inside them.If a namespace already exists, for example a company-managed
cert-managernamespace, the chart skips adopting it and prints a note. Helm does not patch labels on unmanaged pre-existing namespaces, so missing labels must be applied separately.Install shape
Validation
Also validated the namespace lifecycle in kind for:
cert-managernamespace