fix(picker): a non-git Project shows no marker and a muted not a git repo (#87) - #88
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
A directory added with
cdd addthat is not a git repo no longer reads as a failure.git.GetStatusalready reportsNotRepo(no.git) separately fromUnknown, so only the Picker's rendering changed:NotRepo(its status column width is 0)not a git repo;branchandsyncstay omitted!stays forUnknown(a real git failure in a repo). Its preview text is nowgit could not read it, sinceUnknownis not only a timeout!still means unknown, and a non-git row shows no glyph to explainHow verified
TestView_NotRepoIsNeutral), andUnknownkeeping its!(TestView_UnknownStaysRed); the existing status-keying test now usesUnknownfor its!rowgofmt -l .empty,go vet ./...andgolangci-lint run ./...cleango test ./...passes except the known local-only fish cases ofTestScriptExecutionCloses #87