Ensure part_of_a_transaction only runs in tests#159
Open
meshy wants to merge 1 commit into
Open
Conversation
meshy
commented
May 6, 2026
Comment on lines
+71
to
+72
| if len(connection.atomic_blocks) == 0: | ||
| raise _OnlyForUseInTests |
Collaborator
Author
There was a problem hiding this comment.
Question: Is there any reason why this should be behind a setting? My feeling is that a setting will only enable abuse of this test util.
Collaborator
There was a problem hiding this comment.
I don't think we should put this behind a setting. We can always add one later if a use case is discovered.
meshy
commented
May 6, 2026
LilyFirefly
approved these changes
May 7, 2026
Comment on lines
+71
to
+72
| if len(connection.atomic_blocks) == 0: | ||
| raise _OnlyForUseInTests |
Collaborator
There was a problem hiding this comment.
I don't think we should put this behind a setting. We can always add one later if a use case is discovered.
Before this change, `part_of_a_transaction` could have been used in production code (or transaction test cases) where it would have actually done a `COMMIT`, and Django would have run after-commit callbacks. This breaks the expectations of `part_of_a_transaction` because in those cases it really is a transaction. Now we'll raise an error if there is no test transaction detected.
meshy
force-pushed
the
meshy/part_of_a_transaction-fail-outside-tests
branch
from
46693f1 to
13e8350
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change,
part_of_a_transactioncould have been used in production code (or transaction test cases) where it would have actually done aCOMMIT, and Django would have run after-commit callbacks. This breaks the expectations ofpart_of_a_transactionbecause in those cases it really is a transaction.Now we'll raise an error if there is no test transaction detected.
Fixes #154