Skip to content

Develop#2

Merged
miniwa00 merged 4 commits into
mainfrom
develop
Sep 20, 2025
Merged

Develop#2
miniwa00 merged 4 commits into
mainfrom
develop

Conversation

@miniwa00

@miniwa00 miniwa00 commented Sep 20, 2025

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Streamlined CI/CD by removing redundant deployment workflows.
    • Standardized environment suffix handling and updated deployment document naming for consistency across environments.
    • Enhanced deployment logs and comments for clearer operations visibility.
    • Expanded ignore rules to exclude common Python build/cache artifacts, reducing noise in version control.
    • No user-facing changes; application behavior remains unchanged.

@miniwa00 miniwa00 requested a review from Fletacode September 20, 2025 05:46
@coderabbitai

coderabbitai Bot commented Sep 20, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

This PR updates one deployment workflow to use a lowercased environment suffix in the SSM document name, expands .gitignore for Python artifacts, and removes two other GitHub Actions workflows previously responsible for deployments.

Changes

Cohort / File(s) Summary
Workflow update: env suffix + SSM document name
.github/workflows/deploy-database-api.yml
Introduces ENV_SUFFIX_LOWER (lowercased ENV_SUFFIX) and updates the SSM document name to KookminFeed-DeployApplication-${ENV_SUFFIX_LOWER}; retains existing deploy steps/parameters.
Workflow removals
.github/workflow/develop.yml, .github/workflows/main.yml
Deletes two deployment workflows, including their triggers, AWS credentials setup, SSM document resolution, send-command, waiting, status/log retrieval, and error handling.
Ignore rules expansion
.gitignore
Adds patterns to ignore Python bytecode/cache files (e.g., pycache/, *.pyc, *.pyo, *.pyd, *$py.class); keeps supervisord.pid ignored.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant GH as GitHub Actions (deploy-database-api.yml)
  participant AWS as AWS STS/OIDC
  participant SSM as AWS SSM
  participant EC2 as EC2 Instance

  GH->>AWS: Assume role via OIDC (configured region)
  Note over GH: Compute ENV_SUFFIX_LOWER from ENV_SUFFIX
  GH->>SSM: send-command(document=KookminFeed-DeployApplication-${ENV_SUFFIX_LOWER}, params: service, branch, envContent)
  GH-->>SSM: Poll command status
  SSM->>EC2: Execute document with parameters
  EC2-->>SSM: Command output/status
  SSM-->>GH: Final status and logs
  Note over GH: Handle success/failure based on command status
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • Develop #1 — Also modifies GitHub Actions-based deploy via AWS SSM, likely touching similar document naming and deployment steps.

Poem

A whisk of env to lowercase lands,
SSM scrolls switch in careful hands.
Two old drums silent, no more to play,
Git’s broom sweeps pyc away.
I thump approval—deploys more neat,
Carrot logs crisp, the pipeline sweet. 🥕

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 193378c and 8072e05.

⛔ Files ignored due to path filters (4)
  • __pycache__/main.cpython-39.pyc is excluded by !**/*.pyc
  • config/__pycache__/__init__.cpython-39.pyc is excluded by !**/*.pyc
  • config/__pycache__/db_config.cpython-39.pyc is excluded by !**/*.pyc
  • config/__pycache__/env_loader.cpython-39.pyc is excluded by !**/*.pyc
📒 Files selected for processing (4)
  • .github/workflow/develop.yml (0 hunks)
  • .github/workflows/deploy-database-api.yml (1 hunks)
  • .github/workflows/main.yml (0 hunks)
  • .gitignore (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@miniwa00 miniwa00 closed this Sep 20, 2025
@miniwa00 miniwa00 reopened this Sep 20, 2025
@miniwa00 miniwa00 merged commit 5bfe153 into main Sep 20, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant