Skip to content

fix: resolve dark mode toggle functionality in navbar#847

Open
Satyam2307 wants to merge 1 commit into
komalharshita:mainfrom
Satyam2307:fix/dark-mode-toggle
Open

fix: resolve dark mode toggle functionality in navbar#847
Satyam2307 wants to merge 1 commit into
komalharshita:mainfrom
Satyam2307:fix/dark-mode-toggle

Conversation

@Satyam2307

@Satyam2307 Satyam2307 commented Jun 11, 2026

Copy link
Copy Markdown

Description

This PR fixes the dark mode toggle button in the navbar that was not switching the application theme.

Changes Made

  • Fixed theme toggle handler to correctly update theme state.
  • Ensured ThemeProvider wraps the application.
  • Applied theme changes to the document using data attributes/classes.
  • Added theme persistence using localStorage.
  • Verified dark theme styles are correctly applied across the application.
  • Ensured the navbar toggle updates the UI immediately.

Result

  • Clicking the moon icon now switches between light and dark themes.
  • Theme changes are reflected across the application.
  • User preference persists after page refresh.

fixes #839

@vercel

vercel Bot commented Jun 11, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first pull request to DevPath.

Before review:

  • Complete the PR template fully
  • Ensure all tests pass
  • Link your PR to an issue
  • Keep changes scoped to the issue

A maintainer will review your contribution soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dark Mode Toggle Button Not Working

1 participant