refactor(dataTable): mantineify table media preview DEV-2062#7289
Open
magicznyleszek wants to merge 4 commits into
Open
refactor(dataTable): mantineify table media preview DEV-2062#7289magicznyleszek wants to merge 4 commits into
magicznyleszek wants to merge 4 commits into
Conversation
magicznyleszek
marked this pull request as ready for review
July 21, 2026 13:17
Contributor
|
Comment on lines
+88
to
+90
| children: args.modalContent ?? ( | ||
| <TableMediaPreview questionType={QUESTION_TYPES.text.id} displayValue={args.displayValue} /> | ||
| ), |
Contributor
There was a problem hiding this comment.
Automatic Text Direction Is Lost
The old text modal wrapped both plain and custom content in dir='auto', but this branch mounts the content directly. Transcript, translation, or qualitative-response text beginning with an RTL script can therefore inherit the wrong direction and render with incorrect alignment or bidirectional ordering.
Suggested change
| children: args.modalContent ?? ( | |
| <TableMediaPreview questionType={QUESTION_TYPES.text.id} displayValue={args.displayValue} /> | |
| ), | |
| children: ( | |
| <div dir='auto'> | |
| {args.modalContent ?? ( | |
| <TableMediaPreview questionType={QUESTION_TYPES.text.id} displayValue={args.displayValue} /> | |
| )} | |
| </div> | |
| ), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Checklist
#Support Docs Updates, if any<type>(<scope>)<!>: <title> DEV-1234Front endand/orBack endorworkflow📣 Summary
Migrates Table Media Preview modal and Text Modal to the Mantine modal flow, removes the legacy BigModal path for table media preview, and adds stable offline-safe DataTableCell stories for media behaviors.
💭 Notes
Changes here:
bigModal.jsandconstants.ts.TableMediaPreview.tsxTableMediaPreviewModalTitle.tsxopenTableMediaPreviewModal.tsxtableMediaPreview.utils.tsTableMediaPreview.module.scssindex.tsMediaCell.tsxandTextModalCell.tsxnow both use newTableMediaPreviewDataTableCell.stories.tsxhas few new stories and now correctly opens the modal when clicked (provider was missing)👀 Preview steps
text,image,audioandvideoquestions and a submission. Also a transcript, translation and qual question response.