refactor(dataTable): mantineify table settings modal DEV-2062#7288
Open
magicznyleszek wants to merge 1 commit into
Open
refactor(dataTable): mantineify table settings modal DEV-2062#7288magicznyleszek wants to merge 1 commit into
magicznyleszek wants to merge 1 commit into
Conversation
Contributor
|
| const { close } = openTableSettingsModal({ | ||
| asset: this.props.asset, | ||
| }) | ||
| this.closeTableSettingsModal = close |
Contributor
There was a problem hiding this comment.
| const { close } = openTableSettingsModal({ | ||
| asset: this.props.asset, | ||
| }) | ||
| this.closeTableSettingsModal = close |
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Checklist
#Support Docs Updates, if any<type>(<scope>)<!>: <title> DEV-1234Front endand/orBack endorworkflow📣 Summary
Migrated Table Settings modal to Mantine Modal, migrated the in-modal component to TypeScript and made it a functional component that uses Mantine components. Also fixed "Reset" button to use proper defaults.
💭 Notes
Changes here:
openTableSettingsModal.tsx.bigModal.jsandconstants.ts.TableSettings.tsxis now a functional component in TypeScript.tableStoreto not limit the amount of changes in this PRtableStore.tsso reset values are properly removed before saving.👀 Preview steps