feat(bulkProcessing): add bulk translation modal DEV-1414#7134
Open
duvld wants to merge 71 commits into
Open
Conversation
…lationModal.tsx Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…lationModal.tsx Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
duvld
changed the title
….com/kobotoolbox/kpi into anji/dev-1414-bulk-translation-modal
Member
Author
|
@greptile-apps please re-review |
…-bulk-translation-modal
…com/kobotoolbox/kpi into anji/dev-1419-bulk-transcript-modal
…-bulk-translation-modal Conflicts: jsapp/js/components/submissions/table.tsx
…-bulk-translation-modal Conflicts: jsapp/js/components/submissions/table.tsx
magicznyleszek
requested changes
Jun 15, 2026
magicznyleszek
left a comment
magicznyleszek
left a comment
Member
There was a problem hiding this comment.
Looks ok, bulk processing doesn't work (I suspect BE issues, already talking about this on Zulip). I have to ideas to refactor a bit, other than that good :)
| <Text size='xs'> | ||
| {t('Automatic translation is provided by Google Cloud Platform.')} | ||
| | ||
| <Anchor href={envStore.data.support_url + GOOGLE_TRANSCRIPTION_LANGUAGE_SUPPORT_URL} underline='always'> |
Member
There was a problem hiding this comment.
Nice for using Anchor, please make it target blank :)
| props.onRequestClose() | ||
| props.onSuccess() | ||
| }, | ||
| onError: () => { |
Member
There was a problem hiding this comment.
See my commit from the other PR 55d4448 and handle errors in similar way here
| return ( | ||
| <> | ||
| {showWarningModal && ( | ||
| <Stack gap='md'> |
Member
There was a problem hiding this comment.
Both modals have identical warning modal, extract to a shared component (maybe BulkProcessingWarningModal.tsx?) And maybe move both modals to some `…/js/components/submissions/bulkProcessing/ directory?
Conflicts: jsapp/js/components/languages/RegionSelector.tsx jsapp/js/components/submissions/BulkTranscriptionModal/BulkTranscriptionModal.tsx jsapp/js/components/submissions/table.tsx
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Checklist
#Support Docs Updates, if any<type>(<scope>)<!>: <title> DEV-1234Front endand/orBack endorworkflow📣 Summary
Adds modal to allow bulk translation for multiple transcripts
💭 Notes
Very similar to BulkTranscriptionModal with key differences in time estimation and props
👀 Preview steps