WIP: npm deps ci improvements#7074
Conversation
Include repository and os arch, too. Makes debugging quicker in the future by ruling out problem sources.
As each dependabot PR appears, every commit should be a brand new node_modules state. Caching isn't useful until there are other commits that would reuse it. So during the speculative stage of dependabot PR's, we may as well save our storage capacity. They'll appear in the cache after the `main` CI runs.
|
| "rtl-detect": "^1.1.2", | ||
| "select2": "^3.5.2-browserify", | ||
| "use-immer": "^0.10.0", | ||
| "wretch": "^2.9.0", | ||
| "wretch": "^2.11.1", | ||
| "zxcvbn": "^4.4.2" | ||
| }, | ||
| "devDependencies": { | ||
| "@babel/preset-env": "^7.22.5", | ||
| "@0x6b/ttf2woff2-wasm": "^0.11.1", | ||
| "@babel/preset-env": "^7.29.5", | ||
| "@biomejs/biome": "^1.9.4", | ||
| "@eslint/compat": "^1.2.4", | ||
| "@eslint/compat": "^1.4.1", | ||
| "@eslint/eslintrc": "^3.3.5", | ||
| "@eslint/js": "^9.17.0", | ||
| "@eslint/js": "^9.39.4", | ||
| "@faker-js/faker": "^9.9.0", | ||
| "@jest/create-cache-key-function": "^30.3.0", | ||
| "@pmmmwh/react-refresh-webpack-plugin": "^0.5.10", | ||
| "@storybook/addon-a11y": "^9.0.0-beta.11", | ||
| "@storybook/addon-docs": "^9.0.17", | ||
| "@storybook/addon-links": "^9.1.3", | ||
| "@jest/create-cache-key-function": "^30.4.1", |
There was a problem hiding this comment.
Several packages downgraded, not upgraded
wait-on went from ^9.0.5 → ^7.2.0 (two major versions back), globals from ^15.14.0 → ^14.0.0, fork-ts-checker-webpack-plugin from ^9.1.0 → ^8.0.0, and style-loader from ^4.0.0 → ^3.3.4. Intentional downgrades are sometimes necessary to resolve compatibility issues, but without any notes in the PR it is hard to know what drove each one. Future contributors could re-raise them during a routine bump and hit the same problem again.
There was a problem hiding this comment.
Yes, I thought that was odd, too. I believe that happened after I ran a dedupe command.
For example, I think fork-ts-checker-webpack-plugin was unified with the storybook subdependency:
aube why fork-ts-checker-webpack-plugin
@kobotoolbox/kpi@2.0.0 /home/phil/k/kpi
devDependencies:
@storybook/react-webpack5 9.1.20
└── @storybook/builder-webpack5 9.1.20
└── fork-ts-checker-webpack-plugin 8.0.0
fork-ts-checker-webpack-plugin 8.0.0
I'll probably revert the dedupe step before marking this for review.
Upgrading our top-level dependencies is more important to me than unifying in these cases, although I could see a case for overriding the subdependencies if they're compatible.
Pushing some WIP commits. Not ready for review yet. —phil
Working on:
🗒️ Checklist
#Support Docs Updates, if any<type>(<scope>)<!>: <title> DEV-1234Front endand/orBack endorworkflow📣 Summary
TODO
📖 Description
TODO
👷 Description for instance maintainers
TODO
💭 Notes
TODO
👀 Preview steps