Fix issue with route scope binding when getRouteKeyName method is different from Route scoped#972
Open
Joemires wants to merge 4 commits into
Open
Fix issue with route scope binding when getRouteKeyName method is different from Route scoped#972Joemires wants to merge 4 commits into
Joemires wants to merge 4 commits into
Conversation
Contributor
|
I probably only know about 30% of Laravel features at this point. 😅 |
Contributor
|
Please fix the tests + add a new one for this use case, if possible. |
Contributor
|
Tests fixed (wasn't your fault), but can you add a test for this too? |
Author
|
Hey @shalvah I'll look into this and revert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a problem when you are using
The documentation still uses your
getRouteKeyNamemodel method and this is a great problem for people with special routes having their special scopes