Add domain option to the laravel config section so docs can live on a separate hostname#1002
Closed
dazza-dev wants to merge 2 commits into
Closed
Add domain option to the laravel config section so docs can live on a separate hostname#1002dazza-dev wants to merge 2 commits into
dazza-dev wants to merge 2 commits into
Conversation
Contributor
|
Thanks for identifying a problem and trying to fix it! I won't be accepting this, though. As a rule, I reject any new additions to the config file. It's already quite big, and if an addition is not relevant to the majority of users, it's not worth increasing the size of this file (which hurts its usability). Your use cases in particular can already be solved with a workaround:
I agree it may be less than ideal, so I'm open to other solutions (eg custom hooks). But the config file is for the 90% use case, not the 10%. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behaviour
The laravel section of config/scribe.php lets you tweak docs_url, asset folder, middleware, etc., but there’s no way to put the generated documentation behind a different domain or sub-domain. Today you have to copy the route declaration and wrap it in Route::domain() yourself each time you publish the config.
Impact
Non-breaking: existing installations keep working as domain defaults to null.
Zero maintenance cost: publishing the config once exposes the new env var for developers who need it.