This repository was archived by the owner on Jun 23, 2021. It is now read-only.
Permissions fix for containerized environments (Sail)#6
Open
Timic3 wants to merge 1 commit into
Open
Conversation
Collaborator
|
Hmm, it'll probably fix it, but I'm not sure if this'll fly on Windows. I'll need to check it out first. |
Author
|
You're probably right, should add a check for OS or something; it could also be an issue with my Sail setup - I'll try with a clean project when I find the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small pull request fixes a bug with permissions inside a Docker container.
I'm not sure if it's WSL 2 specific or Sail specific or just permissions in general, but for some reason, it couldn't generate HTML files successfully and it kept throwing an exception. Exception trace is below.
Trace
Note that this is a fast fix, it probably could've been fixed in a more elegant way (using Docker or something), but this what I had come up with in a few minutes (excluding messing with Composer). I'm using the fork in my work project and works fine.