Conversation
…source) (#666) The report lands beside the selected output file, and the output defaults to the CWD (cli.py:469-473) — any generate-context run whose working directory is the core tree, including a failing one (the config- resolution error fires inside the step_context), rewrites the tracked file and dirties the checkout. The committed copy is a developer's 2026-09-03 test run (a /private/var/folders path, cost_usd: 0.010293). Fix: git rm the tracked copy + .gitignore the filename. The report continues to be written (the step_context contract is unchanged) — it just stops being source. Fixes #666 Agent: ISSUES-TO-PR ses_f3e7372a5ffe3b2I6lP4Wm3w2d
|
Status: ON HOLD — do not merge. The adversarial review (2026-09-22) found defects in this PR that need rewriting before it can merge. The specific finding is in the review record. The PR is being rewritten; the current branch and all evidence are preserved. Agent: ISSUES-TO-PR ses_f3e7372a5ffe3b2I6lP4Wm3w2d |
The previous .gitignore contained only a comment — no pattern. The deleted file would be re-tracked on the next generate-context run. This adds the actual filename as the ignore pattern. Fixes the gitignore half of #666 (the cli.py CWD-default half is out of scope — named). Agent: ISSUES-TO-PR ses_f3e7372a5ffe3b2I6lP4Wm3w2d
|
A sibling-sweep note from the triage pass: |
|
Hold lifted at 7e7b909: the containment hold (2026-09-22 10:41Z) is superseded — the branch now carries the actual |
1 participant
What
Untracks
libs/openant-core/generate-context.report.json— a run artifact committed in PR #446 — and adds it to.gitignore. Closes #666.Why
The file is a developer's test output (a macOS scratch path in
inputs.repo_path,cost_usd: 0.010293, a 2026-09-03 timestamp), not source. The generate-context step writes its report beside the selected output file, and the output defaults to the CWD (cli.py:469-473), so any generate-context run from the core tree — including a failing one (the config-resolution error fires insidestep_context, which finalizes the report withstatus: error) — rewrites the tracked file and dirties the checkout.The issue's executed repro proved it: a failing run (a nonexistent
--llm-config) rewrote the tracked file, changing its status fromsuccesstoerror, onegit add -Aaway from committing a fresh run's numbers.The fix
Two lines:
git rmthe tracked copy +.gitignorethe filename. The report continues to be written (the step-context contract is unchanged) — it just stops being source.Leak-scan note
The diff-scan flags the deleted file's committed
/var/folders/...path (a block-tier finding). That path is in the deletion lines — the very content this PR removes from source. The scanner correctly found it; the fix is its remedy.Testing
No test changes — a pure git-hygiene fix (the tracked-file removal doesn't affect any test path). The full suite runs identically before and after.
Fixes #666
Agent: ISSUES-TO-PR ses_f3e7372a5ffe3b2I6lP4Wm3w2d