You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
❌ Patch coverage is 85.52632% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.82%. Comparing base (1ddad5c) to head (34b6002).
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The publish workflow can release the alpha under latest, while dependency handling can overwrite host versions, discard the binding’s required dependencies, and leave saved versions unpinned.
When a project already directly depends on @emnapi/core or @emnapi/runtime 1.x, these commands overwrite that dependency with 2.0.0-beta.2 in the project's manifest. That can break the project's existing consumers or fail peer-dependency resolution before the binding is installed. Keep the WASM runtime dependencies isolated from existing project dependencies instead of upgrading unrelated direct dependencies in place.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Critical dependency-policy gaps can leave the WASM binding incompatible in workspaces, with non-exact version requests, or during fixture setup, and clean browser builds lack the transform binding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a plan for addressing CDN drift with transitive deps. Publish a v2 alpha for development of the cdn drift plan.