Claude/review approach terminology 011 c ur yth dd jv kkf b4sx gxr1#16
Merged
kluth merged 4 commits intoNov 7, 2025
Merged
Conversation
- Add base path /synapse/ for production builds - Fixes asset loading on GitHub Pages (kluth.github.io/synapse) - Assets now correctly load from /synapse/assets/ instead of /assets/ - Development builds still use root path for local testing
- 4-layer testing strategy: Unit, Interaction, Visual Regression, E2E - Chromatic integration for automatic visual regression - Storybook interaction testing with play functions - Playwright E2E with cross-browser support - Accessibility testing with axe-core - Complete CI/CD pipeline configuration - TDD workflow with visual testing - 4-week implementation timeline
Following TDD and visual testing strategy from VISUAL_TESTING_PLAN.md Added play functions to test: - Primary: Button visibility, variant class, disabled state, click interactions - Disabled: Button disabled state, disabled class, click prevention - KeyboardNavigation (new): Focus management, Enter/Space key activation, Tab navigation Benefits: - Automated interaction testing in Storybook UI - Visual verification of component behavior - Tests run automatically when viewing stories - Foundation for comprehensive visual testing Tagged stories automatically detected by Storybook (play-fn tag) Test coverage: - Click interactions - Keyboard navigation (Enter, Space, Tab, Shift+Tab) - Disabled state verification - Focus management - Accessibility improvements Next steps: - Add interaction tests to remaining components - Set up Chromatic for visual regression - Add E2E tests with Playwright
kluth
deleted the
claude/review-approach-terminology-011CUrYthDdJVKkfB4sxGXR1
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.