Improve color handling for highlight & introduction blocks#592
Open
danalvrz wants to merge 4 commits into
Open
Improve color handling for highlight & introduction blocks#592danalvrz wants to merge 4 commits into
danalvrz wants to merge 4 commits into
Conversation
Collaborator
Author
|
@sneridagh We need kitconcept/volto-highlight-block#14 and a new release to fix the failing test. Since we are not forcing the white font at VLT level anymore for the variation 2 of the Highlight block, it is not passing the contrast check. |
Member
|
@danalvrz is this a breaking change? I guess, right? It's no problem, but we need to mark it and release as it. |
Collaborator
Author
|
@sneridagh I would consider this only affects internal implementation, not external behavior. |
davisagli
force-pushed
the
improve-highlight-colors
branch
from
434c510 to
1785d71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.