Repository navigation
Show payment number as a clickable link on payments page - #680
Open
tungleduyxyz wants to merge 2 commits into
Open
tungleduyxyz wants to merge 2 commits into
tungleduyxyz wants to merge 2 commits into
Conversation
The payment number link was styled gray because it is not in the first column, so users could not tell it was clickable. Give it the primary color, matching the invoice number on the invoices page. Fixes #679 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Creating a role from the Roles page redirected to the Users page (admin_allowed_users_path). Redirect to role_definitions_path instead, like update does, and include the role name in the notice. The redirect back to the user form when role_return_context is set is unchanged. Fixes #676 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019weYmgsSiSk5p81HyRnyty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #679
Problem
On the Payments list, the payment number is a link to the payment details, but it is gray like the rest of the row, so users can't tell it is clickable. The invoice number on the Invoices list is blue.
The difference comes from column order.
datatable.csscolors links blue only in the first column, andpayment.cssforces links in every other column to gray. On the Invoices listinvoice_numberis the first column. On the Payments listpayment_datecomes first andpayment_numberis second.Change
lib/kaui.rb: add apayment-number-linkclass to the payment number link.payment.css: stylea.payment-number-linkwith--kb-primaryand font-weight 600, matching the invoice number.This applies to both the global Payments page and the payments tab on an account page.
🤖 Generated with Claude Code