Skip to content

Open sidebar on mouseover if not fixed.#231

Open
soerendomroes wants to merge 3 commits into
mainfrom
sdo/sidebarOnHover
Open

Open sidebar on mouseover if not fixed.#231
soerendomroes wants to merge 3 commits into
mainfrom
sdo/sidebarOnHover

Conversation

@soerendomroes

Copy link
Copy Markdown
Member

Fixes #213

By checking the panel id instead of contacting the renderoptions registry, this works very well.

However, this will open the sidebar onmouseover even though it is not pinned to be more reactive.

Maybe it would be a better idea to cache the pinned status rather than looking in the registry.

@Eddykasp Eddykasp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this mainly needs user approval, which we can discuss in a meeting, but I think it's a good improvement.

@NiklasRentzCAU NiklasRentzCAU left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our feedback from the discussion was that this should include the following changes:

  • most recently opened pane should be reopened
  • lock should toggle between always use click or always use hover

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change lock/unlock sidebar option to Click/Hover

3 participants