Refactor/buf doc loading#86
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
e892e58 to
5dd9bcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a lightweight buffer state flag to distinguish between flat text buffers and tir-buf buffers.
Previously, the buffer type could be inferred by scanning the entire buffer content and checking whether it contained pipe (
|) characters. While this approach worked, it required reading the full buffer repeatedly and introduced unnecessary overhead.To avoid that cost, this PR stores the buffer state (
FLAT) as a buffer-local flag instead.In addition, this PR includes some internal cleanup:
Notes
The new flag slightly increases internal state management complexity, but should improve performance and simplify buffer-type checks in hot paths.