Refactor/range slice unification#80
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
kibi2
force-pushed
the
refactor/range-slice-unification
branch
from
1d02e3a to
7482c39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unify range slicing logic shared by
Range[]andAttr[].Changes
Added generic range access utility:
Range.get_range(item)Shared slice implementation for:
Range[]Attr[]Removed need for metatable-based method dispatch
Kept data structures serializable and deepcopy-safe
Motivation
Tirenvi frequently stores internal state in:
Metatable methods may be lost during serialization or msgpack conversion.
This change keeps range-related objects as plain Lua tables while still allowing shared range operations.