Repository navigation
Make the Sky Clock's stone and rain look less drawn - #211
Merged
Merged
Conversation
The stone read as cartoony: its chips were flat dark spots on a clean outline, its face was soft blotches, and rain left round pale beads on it. - Chips are now small angular notches broken out of the outline (cut through the figure's depth, tapering in), with a soft shadow round them; the foot stays whole. Edge light, frost and snow follow the worn outline instead of the clean letter. - The face is mottled at two scales under the speckle, with smaller, harder grime. - Rain on the stone is a faint sky sheen near the top and thin dark runs with a pinpoint of light; no beads. - Falling rain is finer and fainter, in two depths. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GabHbsRZxjJVzRxVEsurj7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: none
Security implication: none, drawing only.
Consumer-verified: n/a
Foundry compatibility: n/a. This is a canvas drawing change only, rendered with Foundry stubs in Chromium; the live check is in #210.
Mockup: Sky Clock mockup, version 11, on the Chronicle Sign-offs stone weather card (approved).
What this changes
On the stone weather card, Key Maker said the stone had gone "a bit more cartoony again" and that the rain on it also looked cartoony. This PR makes three fixes.
Chips. They used to be flat, dark, rounded spots on a clean outline. Now they are small angular notches broken out of the outline itself, tapering in through the figure's depth with a soft shadow around them. The foot stays whole.
crumble()(notch plusextsweep),shapeOf()(each chip's outward direction) and theMASKsnapshot thatedge()now reads.Stone face. The face gets two scales of mottling under the speckle, so its tone varies across the surface. The soft grime blotches are now smaller and harder-edged (
grainCanvas,weatherCanvas).Rain.
stoneMarks).drawFront).Why
These are follow-ups to #209 from the stone weather card review. The look is still a dark weathered stone in Alfa Slab One, as signed off.
Test plan
CHRONICLE_DIR=../Chronicle node --test tools/test-sky-clock.mjs: 17 pass, 0 failtools/test-*.mjssuite gave 1396 pass and 1 fail. The failure istest-shop-room's "vendored files match Chronicle" check, and it fails the same way on main against my local Chronicle checkout. It is not related to this PR.tools/check-comment-clutter.sh: OKSkyClockwas rendered with Foundry stubs in Chromium in 12 weathers (clear, rain, snow, thunderstorm, blizzard, hail, fog, sandstorm, ice storm, autumn leaves, heat wave, luminous sky), with no page errors.Tenet self-check