Fix/confd hardening - #1659
Merged
Merged
Fix/confd hardening#1659
Conversation
mattiaswal
force-pushed
the
fix/confd-hardening
branch
10 times, most recently
from
September 28, 2026 11:13
8bc5f03 to
23478f2
Compare
The name reaches iw.py and the hostapd path; the pattern allows every probed name, including device-tree unit addresses like sfp@9.
Its rc.d scripts and default files run as root.
Both are written into the dnsmasq dhcp-host line.
Both are written into quoted fields in syslog.conf.
The names are passed to mksshkey and used as file names.
Without it a syslog-only change took effect only after reboot.
Written into wpa_supplicant/hostapd config; AP/mesh passphrases now validated like station.
The name reaches the dagger shell scripts unquoted, so a metacharacter runs as root or leaves a config dagger cannot apply. Fixes #1655
mattiaswal
force-pushed
the
fix/confd-hardening
branch
from
September 28, 2026 11:14
23478f2 to
a9dc6ad
Compare
mattiaswal
marked this pull request as ready for review
September 28, 2026 11:19
Each node must list the other two as peers, not just any two. Signed-off-by: Mattias Walström <lazzer@gmail.com>
The value is written into the udhcpc command line of the generated Finit service file, fixes #1657.
'get mesh_param' without a parameter only lists the names and exits 1, so forwarding was never reported. Signed-off-by: Mattias Walström <lazzer@gmail.com>
troglobit
approved these changes
Sep 29, 2026
troglobit
left a comment
troglobit
left a comment
Contributor
There was a problem hiding this comment.
Awesome work, very clean commits, easy to follow! 💪
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc hardening, limit some input fields harshly.
fixes #1657
fixes #1655
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: