Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #757
Problem
After #737, global filters lived in the radix tree alongside path-specific ones.
call_block_for_path_typeran the*filters explicitly, then the radix lookup for the request path matched the same*catch-all again — sobefore_allblocks ran twice per request (duplicated DB/auth calls).A related edge case:
before_all "/*"registers on a different key thanbefore_all, so/could miss the global filter entirely when another wildcard filter (e.g.before_all "/api/*") was also registered.Solution
Make duplicate execution structurally impossible by separating global filters from the radix tree at registration time:
_add_route_filternormalizes"*"and"/*"into a dedicated@global_filtershash — they never enter the radix treecall_block_for_path_typesimply runs global filters first, then the radix lookup for path-specific filters; the lookup can no longer re-match a global filterbefore_all "/*"now behaves exactly likebefore_all, including on/No dedup bookkeeping or per-request allocations needed.