Skip to content

Fixed failing tests due to the change we check for file readability.#9

Merged
kberov merged 7 commits into
masterfrom
fix_tests
Jul 26, 2025
Merged

Fixed failing tests due to the change we check for file readability.#9
kberov merged 7 commits into
masterfrom
fix_tests

Conversation

@kberov

@kberov kberov commented Sep 29, 2024

Copy link
Copy Markdown
Owner

No description provided.

@HeikoSchlittermann

Copy link
Copy Markdown
Collaborator

I added another commit with a serving suggesting :) I strongly believe, you should not try to parse error strings. Use sentinel errors instead. Or return the errors you got from the os, if possible.

And, if you do fmt.Errorf, use %w to Wrap and not convert the errors.

@kberov

kberov commented Sep 30, 2024

Copy link
Copy Markdown
Owner Author

@HeikoSchlittermann, thanks for the suggestion. In tests now I use errors.Is(...) instead of parsing error strings.

Comment thread examples_test.go Outdated
Comment thread gledki.go Outdated
Comment thread gledki_test.go Outdated
Comment thread gledki_test.go Outdated
@kberov kberov merged commit 8dcf779 into master Jul 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants