fix: correct BPE merge annotations in test_wikipedia_example#111
Open
coding-shalabh wants to merge 1 commit into
Open
fix: correct BPE merge annotations in test_wikipedia_example#111coding-shalabh wants to merge 1 commit into
coding-shalabh wants to merge 1 commit into
Conversation
The docstring incorrectly described the merge sequence as X=ZY, Y=ab, Z=aa. The actual BPE algorithm produces: Z=aa, Y=Za (aaa), X=Yb (aaab), because the most frequent pair at each step is (97,97), then (256,97), then (257,98). Added explicit merge sequence with occurrence counts for clarity. Fixes karpathy#93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_wikipedia_exampledocstringX=ZY, Y=ab, Z=aabut the actual BPE algorithm producesZ=aa, Y=Za (aaa), X=Yb (aaab)Details
The original annotation described the merges as:
But running BPE on
"aaabdaaabac"for 3 merges actually produces:This can be verified with:
The test assertions were already correct (
[258, 100, 258, 97, 99]), only the docstring was wrong.Fixes #93
Test plan
pytest tests/test_tokenizer.py::test_wikipedia_example— both BasicTokenizer and RegexTokenizer pass