Add sdbus-c++ ConnMan client example#16
Merged
Merged
Conversation
Signed-off-by: JianDe <jiande2020@protonmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new ConnMan monitoring example client to the existing set of sdbus-c++ example daemons, enabling basic ConnMan Manager/Technology/Service signal handling and logging.
Changes:
- Introduces a new
connman_clientexecutable with a simple monitor loop and logging. - Implements
ConnmanManagerClientplus Technology/Service proxy wrappers to react to ConnMan signals. - Wires the new example into the top-level build via
add_subdirectory(src/connman).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/connman/main.cc |
New executable entrypoint creating a system bus connection, starting async event loop, and running the shared monitor loop. |
src/connman/connman_client.h |
Declares ConnMan Manager/Technology/Service proxy client classes and internal state maps. |
src/connman/connman_client.cc |
Implements signal handlers and initial enumeration of technologies/services. |
src/connman/CMakeLists.txt |
Builds and installs the new connman_client example. |
CMakeLists.txt |
Adds src/connman subdirectory to the build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
- Constructor exception leak — wrapped post-registerProxy() D-Bus calls in try-catch that calls unregisterProxy() on failure - Unguarded callbacks — added try-catch to all 6 onPropertyChanged/onTechnologyAdded/onTechnologyRemoved/onServicesChanged callbacks - No reconnection — added retry loop with exponential backoff (1s → 30s cap) in main.cc - Unused parameter Signed-off-by: Joel Winarske <joel.winarske@outlook.com>
jwinarske
approved these changes
Mar 20, 2026
Signed-off-by: Joel Winarske <joel.winarske@outlook.com>
Owner
|
@jaydon2020 thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’ve implemented a ConnMan monitoring client as part of an IVI homescreen WiFi plugin. I tested with my raspberry pi 5 with AGL (VERSION="20.91.0 (unagi)").